qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] tests/libqtest: Remove unused gl


From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] tests/libqtest: Remove unused global_qtest-related wrapper functions
Date: Fri, 10 May 2019 10:24:45 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 5/10/19 12:22 AM, Thomas Huth wrote:
> A bunch of the wrapper functions that use global_qtest are not used
> anymore. Remove them to avoid that they are used in new code again.
> 
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  tests/libqtest.c |  11 +----
>  tests/libqtest.h | 108 -----------------------------------------------
>  2 files changed, 1 insertion(+), 118 deletions(-)

Nice!

Reviewed-by: Eric Blake <address@hidden>


> -/**
> - * qtest_irq_intercept_out:
> - * @string: QOM path of a device.
> - *
> - * Associate qtest irqs with the GPIO-out pins of the device
> - * whose path is specified by @string.
> - */
> -static inline void irq_intercept_out(const char *string)

Fixes a copy-and-paste misdocumentation bug while at it :)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]