Re: [Qemu-trivial] [PATCH] kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del

[Yury Kotov]

+ pbonzini@

Ping
This is a simple patch that adds some printfs, was useful in analyzing a bug.
In our case abort() hit without any friendly errors in stdout/stderr.

11.04.2019, 20:49, "Yury Kotov" <address@hidden>:
> Signed-off-by: Yury Kotov <address@hidden>
> ---
>  accel/kvm/kvm-all.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index 241db496c3..41586daf4c 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -864,8 +864,8 @@ static void kvm_mem_ioeventfd_add(MemoryListener 
> *listener,
>                                 data, true, int128_get64(section->size),
>                                 match_data);
>      if (r < 0) {
> - fprintf(stderr, "%s: error adding ioeventfd: %s\n",
> - __func__, strerror(-r));
> + fprintf(stderr, "%s: error adding ioeventfd: %s (%d)\n",
> + __func__, strerror(-r), -r);
>          abort();
>      }
>  }
> @@ -882,6 +882,8 @@ static void kvm_mem_ioeventfd_del(MemoryListener 
> *listener,
>                                 data, false, int128_get64(section->size),
>                                 match_data);
>      if (r < 0) {
> + fprintf(stderr, "%s: error deleting ioeventfd: %s (%d)\n",
> + __func__, strerror(-r), -r);
>          abort();
>      }
>  }
> @@ -898,8 +900,8 @@ static void kvm_io_ioeventfd_add(MemoryListener *listener,
>                                data, true, int128_get64(section->size),
>                                match_data);
>      if (r < 0) {
> - fprintf(stderr, "%s: error adding ioeventfd: %s\n",
> - __func__, strerror(-r));
> + fprintf(stderr, "%s: error adding ioeventfd: %s (%d)\n",
> + __func__, strerror(-r), -r);
>          abort();
>      }
>  }
> @@ -917,6 +919,8 @@ static void kvm_io_ioeventfd_del(MemoryListener *listener,
>                                data, false, int128_get64(section->size),
>                                match_data);
>      if (r < 0) {
> + fprintf(stderr, "%s: error deleting ioeventfd: %s (%d)\n",
> + __func__, strerror(-r), -r);
>          abort();
>      }
>  }
> --
> 2.21.0

Regards,
Yury