Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 00/10] Refactor cpu topo into machine properties

[Like Xu]

On 2019/5/19 4:54, Like Xu wrote:
> This patch series make existing cores/threads/sockets into machine
> properties and get rid of global smp_* variables they use currently.
>
> The purpose of getting rid of globals is disentangle layer violations and
> let's do it one step at a time by replacing the smp_foo with qdev_get_machine()
> as few calls as possible and delay other related refactoring efforts.

Hi Eduardo & Igor,
Do you have any comments on this new version of CpuTopology refactoring?

With this series of patch, we may move forward to review [Qemu-devel] 
[PATCH v2 0/5] Introduce cpu die topology and enable CPUID.1F for i386.

Thanks,
Like Xu

> ==changelog==
>
> v3:
>
> - rephrase commit messages
> - s/of/of present/ for CpuTopology comment
> - drop reduanct arguments such as cpu_type
> - use ms instead of macs in migration context
> - rebase to commit 1b46b4daa6

<snip>