Re: [Qemu-trivial] [PATCH v3 1/2] configure: set source_path only once and make its definition more robust

[Laurent Vivier]

Le 26/05/2019 à 16:47, Antonio Ospite a écrit :
> From: Antonio Ospite <address@hidden>
> 
> Since commit 79d77bcd36 (configure: Remove --source-path option,
> 2019-04-29) source_path cannot be overridden anymore, move it out of the
> "default parameters" block since the word "default" may suggest that the
> value can change, while in fact it does not.
> 
> While at it, only set source_path once and separate the positional
> argument of basename with "--" to more robustly cover the case of path
> names starting with a dash.
> 
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Antonio Ospite <address@hidden>
> ---
>  configure | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/configure b/configure
> index 528b9ff705..9f12120ad9 100755
> --- a/configure
> +++ b/configure
> @@ -276,10 +276,10 @@ ld_has() {
>      $ld --help 2>/dev/null | grep ".$1" >/dev/null 2>&1
>  }
>  
> -# default parameters
> -source_path=$(dirname "$0")
>  # make source path absolute
> -source_path=$(cd "$source_path"; pwd)
> +source_path=$(cd "$(dirname -- "$0")"; pwd)
> +
> +# default parameters
>  cpu=""
>  iasl="iasl"
>  interp_prefix="/usr/gnemul/qemu-%M"
> 

Applied to my trivial-patches branch.

Thanks,
Laurent