qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/11] hw: Convert various reset() handler to DeviceReset


From: Peter Maydell
Subject: Re: [PATCH 00/11] hw: Convert various reset() handler to DeviceReset
Date: Tue, 8 Oct 2019 10:47:03 +0100

On Mon, 7 Oct 2019 at 22:24, Eduardo Habkost <address@hidden> wrote:
>
> On Mon, Oct 07, 2019 at 12:01:54PM +0200, Philippe Mathieu-Daudé wrote:
> > Hi Michael,
> >
> > On 10/5/19 11:46 PM, Michael S. Tsirkin wrote:
> > > On Thu, Sep 26, 2019 at 05:17:22PM +0200, Philippe Mathieu-Daudé wrote:
> > > > Hi.
> > > >
> > > > Following the thread discussion between Peter/Markus/Damien about
> > > > reset handlers:
> > > > https://www.mail-archive.com/address@hidden/msg617103.html
> > > > I started to remove qemu_register_reset() calls from few qdevified
> > > > devices (the trivial ones).
> > > >
> > > > Regards,
> > > >
> > > > Phil.
> > >
> > > How do you want these patches merged? Trivial tree?
> >
> > I was hoping Eduardo would take them but he is busy and I even forgot to Cc
> > him. They might go via Trivial or else via Paolo's Misc...
>
> I can merge them if somebody reviews the series.  How exactly are
> we making sure device_reset() is really being called for all
> devices touched by this series?  Are all buses guaranteed to be
> children of main-system-bus?

At least one of them is not (vmcoreinfo), as noted in review
comments on that patch. So while some of these patches might
be ok, some are not, and so we need to review them first
before they get merged via any route I think.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]