[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg optio
From: |
Markus Armbruster |
Subject: |
Re: [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options |
Date: |
Thu, 10 Oct 2019 09:02:01 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 09/10/19 18:44, Mario Smarduch wrote:
>> };
>> @@ -1263,6 +1267,7 @@ static void realtime_init(void)
>> static void configure_msg(QemuOpts *opts)
>> {
>> enable_timestamp_msg = qemu_opt_get_bool(opts, "timestamp", true);
>> + enable_guestname_msg = qemu_opt_get_bool(opts, "name", false);
>> }
>
> Before, the msg option certainly had a timestamp suboption, but this
> might not be the case now. So that "true" needs to become "false".
> I'll fix it up when applying.
Hold your horses.
Before this patch, -msg "" enables timestamps. If you apply it with
your fixup, it doesn't anymore. I don't disagree with that change, but
it needs to be its own commit, with a proper explanation.
I have more comments on this patch.
- [PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs, Mario Smarduch, 2019/10/09
- [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options, Mario Smarduch, 2019/10/09
- [PATCHv2 2/2] target/i386: log MCE guest and host addresses, Mario Smarduch, 2019/10/09
- Re: [PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs, Paolo Bonzini, 2019/10/09
- Re: [PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs, no-reply, 2019/10/09