[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] hw/mem/Kconfig: NVDIMM device requires CONFIG_MEM_DEVICE
From: |
Laurent Vivier |
Subject: |
Re: [RFC PATCH] hw/mem/Kconfig: NVDIMM device requires CONFIG_MEM_DEVICE |
Date: |
Mon, 21 Oct 2019 18:31:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
Le 15/10/2019 à 18:46, Philippe Mathieu-Daudé a écrit :
> When selecting only the NVDIMM device with "NVDIMM y", the
> device is not compiled/linked because it does not select MEM_DEVICE
> and hw/mem/Makefile.objs is not included:
>
> $ git grep mem/ hw/Makefile.objs
> hw/Makefile.objs:39:devices-dirs-$(CONFIG_MEM_DEVICE) += mem/
>
> Let NVDIMM config select MEM_DEVICE.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> I'm not sure this is the best fix, maybe we should simply include
> mem/ regardless of CONFIG_MEM_DEVICE (all mem devices use it).
> ---
> hw/mem/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig
> index 620fd4cb59..5da724d7a2 100644
> --- a/hw/mem/Kconfig
> +++ b/hw/mem/Kconfig
> @@ -7,5 +7,6 @@ config MEM_DEVICE
>
> config NVDIMM
> bool
> + select MEM_DEVICE
> default y
> depends on PC
>
Applied to my trivial-patches branch.
Thanks,
Laurent