[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] configure: Check bzip2 is available

From: Wainer dos Santos Moschetta
Subject: Re: [PATCH v2 2/2] configure: Check bzip2 is available
Date: Fri, 8 Nov 2019 11:33:59 -0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 11/8/19 9:48 AM, Daniel P. Berrangé wrote:
On Fri, Nov 08, 2019 at 12:45:31PM +0100, Philippe Mathieu-Daudé wrote:
The bzip2 tool is not included in default installations.
On freshly installed systems, ./configure succeeds but 'make'
might fail later:

     BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2
   /bin/sh: bzip2: command not found
   make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127
   make: *** Deleting file 'pc-bios/edk2-i386-secure-code.fd'
   make: *** Waiting for unfinished jobs....

Add a check in ./configure to warn the user if bzip2 is missing.

Fixes: 536d2173b2b
Reported-by: Thomas Huth <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
v2: use better English (Daniel)
(Not taking Daniel Reviewed-by because logic changed)
  configure | 4 ++++
  1 file changed, 4 insertions(+)
diff --git a/configure b/configure
index 9b322284c3..2b419a8039 100755
--- a/configure
+++ b/configure
@@ -2147,6 +2147,7 @@ case " $target_list " in
+# Some firmware binaries are compressed with bzip2
Squash into previous patch


  for target in $target_list; do
    case "$target" in
      arm-softmmu | aarch64-softmmu | i386-softmmu | x86_64-softmmu)
@@ -2154,6 +2155,9 @@ for target in $target_list; do
+if test "$edk2_blobs" = "yes" && ! has bzip2; then
+  error_exit "The bzip2 program is required for building QEMU"
feature_not_found() {
Reviewed-by: Daniel P. Berrangé <address@hidden>

Reviewed-by: Wainer dos Santos Moschetta <address@hidden>

- Wainer


reply via email to

[Prev in Thread] Current Thread [Next in Thread]