qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] vhost-user-scsi: fix printf format warning


From: Thomas Huth
Subject: Re: [PATCH] vhost-user-scsi: fix printf format warning
Date: Wed, 11 Dec 2019 20:34:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 11/12/2019 15.23, Paolo Bonzini wrote:
> From: Marc-André Lureau <address@hidden>
> 
> Fixes:
> ../contrib/vhost-user-scsi/vhost-user-scsi.c:118:57: error: format specifies
>       type 'unsigned char' but the argument has type 'int' [-Werror,-Wformat]
>     g_warning("Unable to determine cdb len (0x%02hhX)", cdb[0] >> 5);
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c 
> b/contrib/vhost-user-scsi/vhost-user-scsi.c
> index 0fc14d7..7a1db16 100644
> --- a/contrib/vhost-user-scsi/vhost-user-scsi.c
> +++ b/contrib/vhost-user-scsi/vhost-user-scsi.c
> @@ -115,7 +115,7 @@ static int get_cdb_len(uint8_t *cdb)
>      case 4: return 16;
>      case 5: return 12;
>      }
> -    g_warning("Unable to determine cdb len (0x%02hhX)", cdb[0] >> 5);
> +    g_warning("Unable to determine cdb len (0x%02hhX)", (uint8_t)(cdb[0] >> 
> 5));
>      return -1;
>  }

Reviewed-by: Thomas Huth <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]