[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.0 v3 3/6] hw/pci-host/i440fx: Use size_t to iterate ove
From: |
Laurent Vivier |
Subject: |
Re: [PATCH-for-5.0 v3 3/6] hw/pci-host/i440fx: Use size_t to iterate over ARRAY_SIZE() |
Date: |
Wed, 18 Dec 2019 12:57:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
Le 09/12/2019 à 11:05, Thomas Huth a écrit :
> On 09/12/2019 10.49, Philippe Mathieu-Daudé wrote:
>> We don't enforce the -Wsign-conversion CPPFLAG, but it doesn't hurt
>> to avoid this warning:
>>
>> warning: implicit conversion changes signedness: 'int' to 'size_t' (aka
>> 'unsigned long') [-Wsign-conversion]
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> hw/pci-host/i440fx.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c
>> index fbdc563599..0cc80b276d 100644
>> --- a/hw/pci-host/i440fx.c
>> +++ b/hw/pci-host/i440fx.c
>> @@ -419,12 +419,11 @@ out:
>> static void igd_pt_i440fx_realize(PCIDevice *pci_dev, Error **errp)
>> {
>> uint32_t val = 0;
>> - int i, num;
>> + size_t i;
>> int pos, len;
>> Error *local_err = NULL;
>>
>> - num = ARRAY_SIZE(igd_host_bridge_infos);
>> - for (i = 0; i < num; i++) {
>> + for (i = 0; i < ARRAY_SIZE(igd_host_bridge_infos); i++) {
>> pos = igd_host_bridge_infos[i].offset;
>> len = igd_host_bridge_infos[i].len;
>> host_pci_config_read(pos, len, &val, &local_err);
>>
>
> Reviewed-by: Thomas Huth <address@hidden>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent