Re: [PATCH v1 29/59] cryptodev-vhost.c: remove unneeded 'err' label in cryptodev_vhost_start

[Philippe Mathieu-Daudé]

On 1/6/20 7:23 PM, Daniel Henrique Barboza wrote:
> 'err' can be replaced by 'return r'.
>
> CC: Gonglei <address@hidden>
> Signed-off-by: Daniel Henrique Barboza <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   backends/cryptodev-vhost.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/backends/cryptodev-vhost.c b/backends/cryptodev-vhost.c
> index 8337c9a495..907ca21fa7 100644
> --- a/backends/cryptodev-vhost.c
> +++ b/backends/cryptodev-vhost.c
> @@ -201,7 +201,7 @@ int cryptodev_vhost_start(VirtIODevice *dev, int 
> total_queues)
>       r = k->set_guest_notifiers(qbus->parent, total_queues, true);
>       if (r < 0) {
>           error_report("error binding guest notifier: %d", -r);
> -        goto err;
> +        return r;
>       }
>   
>       for (i = 0; i < total_queues; i++) {
> @@ -236,7 +236,7 @@ err_start:
>       if (e < 0) {
>           error_report("vhost guest notifier cleanup failed: %d", e);
>       }
> -err:
> +
>       return r;
>   }
>