Re: [PATCH v4] target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub

[Paolo Bonzini]

On 29/12/19 03:48, Marek Dolata - address@hidden wrote:
> Fixes: corrects clobbering of registers appearing after k_gs_base
> Buglink: https://bugs.launchpad.net/qemu/+bug/1857640
> 
> Signed-off-by: Marek Dolata <address@hidden>

Queued.  Note that I had to apply the patch by hand since you probably did
some cut-and-paste job.  I also added a meaningful commit message:

    gdb-xml/i386-32bit.xml includes the k_gs_base register too, so we have to
    handle it even if TARGET_X86_64 is not defined.  This is already done in
    x86_cpu_gdb_read_register, but not in x86_cpu_gdb_write_register where the
    incorrect return value causes all registers after it to be clobbered.
    
    Fixes https://bugs.launchpad.net/qemu/+bug/1857640.

Thanks,

Paolo