[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] arm/translate-a64: fix uninitialized variable warning
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2] arm/translate-a64: fix uninitialized variable warning |
|
Date: |
Wed, 8 Jan 2020 13:43:23 +1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 1/8/20 12:39 PM, address@hidden wrote:
> From: Pan Nengyuan <address@hidden>
>
> Fixes:
> target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512':
> target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized
> in this function [-Werror=maybe-uninitialized]
> genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> qemu/target/arm/translate-a64.c:13609:8: error: 'feature' may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> if (!feature) {
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Pan Nengyuan <address@hidden>
> ---
> Changes v2 to v1:
> - add a default label to fix uninitialized warnings(suggested by Richard
> Henderson)
> ---
> target/arm/translate-a64.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Richard Henderson <address@hidden>
Given that you are using -O2, this should probably also be reported as a GCC
bug.
r~