[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/input: Do not enable CONFIG_PCKBD by default
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH] hw/input: Do not enable CONFIG_PCKBD by default |
Date: |
Wed, 15 Jan 2020 14:10:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 15/01/20 12:37, Thomas Huth wrote:
> The i8042 device is part of the chipset of a machine, so it should
> be selected by the machines or chipsets (e.g. SuperIO chipsets),
> and not be enabled by default.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> hw/input/Kconfig | 1 -
> hw/isa/Kconfig | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/input/Kconfig b/hw/input/Kconfig
> index 287f08887b..a2f25725be 100644
> --- a/hw/input/Kconfig
> +++ b/hw/input/Kconfig
> @@ -7,7 +7,6 @@ config LM832X
>
> config PCKBD
> bool
> - default y
> select PS2
> depends on ISA_BUS
>
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 8a38813cc1..c7f07854f7 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -16,6 +16,7 @@ config I82378
> config ISA_SUPERIO
> bool
> select ISA_BUS
> + select PCKBD
>
> config PC87312
> bool
>
Since you CCed qemu-trivial,
Acked-by: Paolo Bonzini <address@hidden>