[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 0/6] Fix more GCC9 -O3 warnings |
Date: |
Sat, 18 Jan 2020 20:24:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 18/12/19 07:05, Markus Armbruster wrote:
> "Chubb, Peter (Data61, Kensington NSW)" <address@hidden>
> writes:
>
>>>>>>> "Philippe" == Philippe Mathieu-Daudé <address@hidden> writes:
>>
>> Philippe> Fix some trivial warnings when building with -O3.
>>
>> For compatibility with lint and other older checkers, it'd be good to keep
>> this as /* FALLTHROUGH */ (which gcc should accept according to its
>> manual).
>
> We have hundreds of /* fall through */ comments already.
>
>> Fixing the comments' placement is a different matter, and should be
>> done. Seems to me that until gcc started warning for this, noone had
>> actually run a checker, and the comments were just for human info.
>>
>> Peter C
>
Queued, thanks.
Paolo
- Re: [PATCH 0/6] Fix more GCC9 -O3 warnings,
Paolo Bonzini <=