qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bsd-user: improve support for sparc syscall flags


From: no-reply
Subject: Re: [PATCH] bsd-user: improve support for sparc syscall flags
Date: Fri, 24 Jan 2020 11:44:40 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [PATCH] bsd-user: improve support for sparc syscall flags

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
74a56ab bsd-user: improve support for sparc syscall flags

=== OUTPUT BEGIN ===
ERROR: else should follow close brace '}'
#47: FILE: bsd-user/main.c:520:
+            }
+            else if (bsd_type == target_netbsd) {

ERROR: else should follow close brace '}'
#104: FILE: bsd-user/main.c:571:
             }
+            else if (bsd_type == target_netbsd) {

ERROR: else should follow close brace '}'
#120: FILE: bsd-user/main.c:587:
+            }
+            else  {

ERROR: code indent should never use tabs
#136: FILE: bsd-user/netbsd/syscall_nr.h:375:
+/*^I$NetBSD: trap.h,v 1.18 2011/03/27 18:47:08 martin Exp $ */$

ERROR: code indent should never use tabs
#140: FILE: bsd-user/netbsd/syscall_nr.h:379:
+ *^IThe Regents of the University of California.  All rights reserved.$

ERROR: code indent should never use tabs
#148: FILE: bsd-user/netbsd/syscall_nr.h:387:
+ *^IThis product includes software developed by the University of$

ERROR: code indent should never use tabs
#149: FILE: bsd-user/netbsd/syscall_nr.h:388:
+ *^ICalifornia, Lawrence Berkeley Laboratory.$

ERROR: code indent should never use tabs
#175: FILE: bsd-user/netbsd/syscall_nr.h:414:
+ *^I@(#)trap.h^I8.1 (Berkeley) 6/11/93$

ERROR: line over 90 characters
#184: FILE: bsd-user/netbsd/syscall_nr.h:423:
+#define        TARGET_NETBSD_SYSCALL_G2RFLAG   0x400   /* on success, return 
to %g2 rather than npc */

ERROR: code indent should never use tabs
#184: FILE: bsd-user/netbsd/syscall_nr.h:423:
+#define^ITARGET_NETBSD_SYSCALL_G2RFLAG^I0x400^I/* on success, return to %g2 
rather than npc */$

WARNING: line over 80 characters
#185: FILE: bsd-user/netbsd/syscall_nr.h:424:
+#define        TARGET_NETBSD_SYSCALL_G7RFLAG   0x800   /* use %g7 as above 
(deprecated) */

ERROR: code indent should never use tabs
#185: FILE: bsd-user/netbsd/syscall_nr.h:424:
+#define^ITARGET_NETBSD_SYSCALL_G7RFLAG^I0x800^I/* use %g7 as above 
(deprecated) */$

ERROR: line over 90 characters
#186: FILE: bsd-user/netbsd/syscall_nr.h:425:
+#define        TARGET_NETBSD_SYSCALL_G5RFLAG   0xc00   /* use %g5 as above 
(only ABI compatible way) */

ERROR: code indent should never use tabs
#186: FILE: bsd-user/netbsd/syscall_nr.h:425:
+#define^ITARGET_NETBSD_SYSCALL_G5RFLAG^I0xc00^I/* use %g5 as above (only ABI 
compatible way) */$

total: 13 errors, 1 warnings, 153 lines checked

Commit 74a56abec155 (bsd-user: improve support for sparc syscall flags) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]