[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block laye
From: |
Kevin Wolf |
Subject: |
Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section |
Date: |
Fri, 7 Feb 2020 15:21:46 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben:
> Philippe Mathieu-Daudé <address@hidden> writes:
>
> > List this file in the proper section, so maintainers get
> > notified when it is modified.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> > Cc: Kevin Wolf <address@hidden>
> > Cc: Max Reitz <address@hidden>
> > Cc: address@hidden
> > ---
> > MAINTAINERS | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 903831e0a4..e269e9092c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1842,6 +1842,8 @@ S: Supported
> Block layer core
> M: Kevin Wolf <address@hidden>
> M: Max Reitz <address@hidden>
> L: address@hidden
> S: Supported
> > F: block*
> > F: block/
> > F: hw/block/
> > +F: qapi/block.json
> > +F: qapi/block-core.json
> > F: include/block/
> > F: qemu-img*
> > F: docs/interop/qemu-img.rst
>
> This is in addition to
>
> Block QAPI, monitor, command line
> M: Markus Armbruster <address@hidden>
> S: Supported
> F: blockdev.c
> F: block/qapi.c
> F: qapi/block*.json
> F: qapi/transaction.json
> T: git https://repo.or.cz/qemu/armbru.git block-next
>
> I'm not sure this section makes much sense anymore.
This is probably for you to decide.
Though the block-next branch from the T: line doesn't even exist any
more...
> Should qapi/transaction.json also be added to "Block layer core"? Or
> should it go into John's section "Block Jobs"?
I think at the moment it only supports actions that are more related to
block jobs, so moving it there would make sense to me.
Kevin
[PATCH 3/3] MAINTAINERS: Cover qapi/trace.json in 'Tracing' section, Philippe Mathieu-Daudé, 2020/02/07