[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] hw: Make MachineClass::is_default a boolean type
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v3 2/3] hw: Make MachineClass::is_default a boolean type |
|
Date: |
Sun, 23 Feb 2020 10:04:58 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 07/02/20 15:25, Michael S. Tsirkin wrote:
>>>> @@ -841,7 +841,7 @@ static void sun4v_class_init(ObjectClass *oc, void
>>>> *data)
>>>> mc->desc = "Sun4v platform";
>>>> mc->init = sun4v_init;
>>>> mc->block_default_type = IF_IDE;
>>>> - mc->max_cpus = 1; /* XXX for now */
>>>> + mc->max_cpus = true; /* XXX for now */
>>
>> and here ^^
>>
>> Thanks,
>> Laurent
>
> Ooh good catch. Which probably means we don't have a unit test for these
"= true" just becomes "= 1".
Paolo
[PATCH v3 3/3] vl: Abort if multiple machines are registered as default, Philippe Mathieu-Daudé, 2020/02/07