qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 01/13] block/stream: Remove redundant statement in stream_


From: Kevin Wolf
Subject: Re: [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run()
Date: Wed, 26 Feb 2020 10:51:02 +0100
User-agent: Mutt/1.12.1 (2019-06-15)

Am 26.02.2020 um 09:46 hat address@hidden geschrieben:
> From: Chen Qun <address@hidden>
> 
> Clang static code analyzer show warning:
>   block/stream.c:186:9: warning: Value stored to 'ret' is never read
>         ret = 0;
>         ^     ~
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> Reviewed-by: John Snow <address@hidden>

Let's mention that this is unnecessary since commit 1d809098aa9.

Since the same commit, the initialisation 'int ret = 0;' is unnecessary
because we never read ret before overwriting the initial value. We could
clean this up in the same patch.

With or without the changes:

Reviewed-by: Kevin Wolf <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]