Re: [PATCH] iotests: Fix nonportable use of od --endian

[Eric Blake]

On 2/25/20 11:43 AM, Max Reitz wrote:
> On 19.02.20 15:41, Eric Blake wrote:
> > Tests 261 and 272 fail on RHEL 7 with coreutils 8.22, since od
> > --endian was not added until coreutils 8.23.  Fix this by manually
> > constructing the final value one byte at a time.
> >
> > Fixes: fc8ba423
> > Reported-by: Andrey Shinkevich <address@hidden>
> > Signed-off-by: Eric Blake <address@hidden>
> > ---
> >   tests/qemu-iotests/common.rc | 22 +++++++++++++++++-----
> >   1 file changed, 17 insertions(+), 5 deletions(-)
> >
> > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> > index 8a6366c09daf..b77ef3d22cd1 100644
> > --- a/tests/qemu-iotests/common.rc
> > +++ b/tests/qemu-iotests/common.rc
> > @@ -56,6 +56,12 @@ poke_file()
>
> I don’t know how you did it, but something in your workflow broke this
> patch.  This should be -56,18 +56,30.

I'm not sure, either.  Would me sending a v2 make it easier?

> (Note that git accepts this patch without error, but it drops everything
> after the first part.  I noticed because your squash-in failed to apply.
>   I suppose I might have noticed later when reviewing, because only
> peek_file_le() was touched, but who knows.)

> With the patch format fixed, and your proposed to-be-squashed patch
> squashed in, there isn’t anything wrong, so:
>
> Reviewed-by: Max Reitz <address@hidden>
>
> But if I’m already about to squash something in, would you allow me to
> rename all instances of “i” to e.g. “byte”?

I'll do that on a v2.


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org