[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 18/18] hw/i386/pc: Clean up includes
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 18/18] hw/i386/pc: Clean up includes |
Date: |
Fri, 28 Feb 2020 12:46:49 +0100 |
Various headers are not required by hw/i386/pc.h:
- "qemu/range.h"
- "qemu/bitmap.h"
- "qemu/module.h"
- "exec/memory.h"
- "hw/pci/pci.h"
- "hw/mem/pc-dimm.h"
- "hw/mem/nvdimm.h"
- "net/net.h"
Remove them.
Add 3 headers that were missing:
- "hw/hotplug.h"
PCMachineState::acpi_dev is of type HotplugHandler
- "qemu/notify.h"
PCMachineState::machine_done is of type Notifier
- "qapi/qapi-types-common.h"
PCMachineState::vmport/smm is of type OnOffAuto
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
include/hw/i386/pc.h | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index d5ac76d54e..6ab6eda046 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -1,20 +1,15 @@
#ifndef HW_PC_H
#define HW_PC_H
-#include "exec/memory.h"
+#include "qemu/notify.h"
+#include "qapi/qapi-types-common.h"
#include "hw/boards.h"
#include "hw/block/fdc.h"
#include "hw/block/flash.h"
-#include "net/net.h"
#include "hw/i386/x86.h"
-#include "qemu/range.h"
-#include "qemu/bitmap.h"
-#include "qemu/module.h"
-#include "hw/pci/pci.h"
-#include "hw/mem/pc-dimm.h"
-#include "hw/mem/nvdimm.h"
#include "hw/acpi/acpi_dev_interface.h"
+#include "hw/hotplug.h"
#define HPET_INTCAP "hpet-intcap"
--
2.21.1
- [PATCH v2 08/18] hw/alpha/dp264: Include "net/net.h", (continued)
- [PATCH v2 08/18] hw/alpha/dp264: Include "net/net.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 11/18] hw/timer/hpet: Include "exec/address-spaces.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 09/18] hw/hppa/machine: Include "net/net.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 10/18] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 12/18] hw/pci-host/q35: Include "qemu/range.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 13/18] hw/i2c/smbus_ich9: Include "qemu/range.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 15/18] hw/acpi: Include "hw/mem/nvdimm.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 14/18] hw/pci-host/piix: Include "qemu/range.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 16/18] hw/i386: Include "hw/mem/nvdimm.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 17/18] hw/pci-host/q35: Remove unused includes, Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 18/18] hw/i386/pc: Clean up includes,
Philippe Mathieu-Daudé <=
- Re: [PATCH v2 00/18] hw: Clean up hw/i386 headers (and few alpha/hppa), Richard Henderson, 2020/02/29