qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] vhost-vsock: fix error message output


From: Laurent Vivier
Subject: Re: [PATCH] vhost-vsock: fix error message output
Date: Tue, 3 Mar 2020 11:16:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

Le 01/03/2020 à 13:03, Nick Erdmann a écrit :
> error_setg_errno takes a positive error number, so we should not invert
> errno's sign.
> 
> Signed-off-by: Nick Erdmann <address@hidden>
> ---
>  hw/virtio/vhost-vsock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-vsock.c b/hw/virtio/vhost-vsock.c
> index 66da96583b..9f9093e196 100644
> --- a/hw/virtio/vhost-vsock.c
> +++ b/hw/virtio/vhost-vsock.c
> @@ -325,7 +325,7 @@ static void vhost_vsock_device_realize(DeviceState
> *dev, Error **errp)
>      } else {
>          vhostfd = open("/dev/vhost-vsock", O_RDWR);
>          if (vhostfd < 0) {
> -            error_setg_errno(errp, -errno,
> +            error_setg_errno(errp, errno,
>                               "vhost-vsock: failed to open vhost device");
>              return;
>          }
> -- 
> 2.25.1
> 


Fixes: fc0b9b0e1cbb ("vhost-vsock: add virtio sockets device")
Reviewed-by: Laurent Vivier <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]