qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] virtfs-proxy-helper: Make the helper_opts[] array const


From: Greg Kurz
Subject: Re: [PATCH 3/3] virtfs-proxy-helper: Make the helper_opts[] array const
Date: Thu, 5 Mar 2020 11:10:15 +0100

On Thu,  5 Mar 2020 02:04:46 +0100
Philippe Mathieu-Daudé <address@hidden> wrote:

> Reduce a bit the memory footprint by making the helper_opts[]
> array const.
> 

... and, maybe most importantly, make it clear helper_opts[] is
not supposed to be modified at runtime.

> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---

Assuming this goes to the trivial tree:

Acked-by: Greg Kurz <address@hidden>

>  fsdev/virtfs-proxy-helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index aa1ab2590d..de061a8a0e 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -43,7 +43,7 @@
>  #define BTRFS_SUPER_MAGIC 0x9123683E
>  #endif
>  
> -static struct option helper_opts[] = {
> +static const struct option helper_opts[] = {
>      {"fd", required_argument, NULL, 'f'},
>      {"path", required_argument, NULL, 'p'},
>      {"nodaemon", no_argument, NULL, 'n'},




reply via email to

[Prev in Thread] Current Thread [Next in Thread]