[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] hw/usb/quirks: Use smaller types to reduce .rodata by 10
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH 3/6] hw/usb/quirks: Use smaller types to reduce .rodata by 10KiB |
|
Date: |
Thu, 5 Mar 2020 12:59:10 +0100 |
> > And went this less intrusive way.
> >
> > I'll respin with s/-1/UINT8_MAX/.
>
> Problem, now this entry is ignored (interface_class==-1):
Yep, "-1" is used as "not used" or "end-of-list" indicator, and it is
outside the valid range to avoid that kind of clashes. You need some
other way to express that if you want go with smaller types which don't
allow values outside the valid range any more. Add a "flags" field for
that maybe?
cheers,
Gerd
[PATCH 2/6] hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB of .bss, Philippe Mathieu-Daudé, 2020/03/04
[PATCH 5/6] ui/curses: Make control_characters[] array const, Philippe Mathieu-Daudé, 2020/03/04
[PATCH 4/6] hw/audio/intel-hda: Use memory region alias to reduce .rodata by 4.34MB, Philippe Mathieu-Daudé, 2020/03/04
[PATCH 6/6] ui/curses: Move arrays to .heap to save 74KiB of .bss, Philippe Mathieu-Daudé, 2020/03/04