[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/9] ui/curses: Make control_characters[] array const
From: |
Stefano Garzarella |
Subject: |
Re: [PATCH v2 7/9] ui/curses: Make control_characters[] array const |
Date: |
Thu, 5 Mar 2020 14:46:00 +0100 |
On Thu, Mar 05, 2020 at 01:45:23PM +0100, Philippe Mathieu-Daudé wrote:
> As we only use this array as input, make it const.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> ui/curses.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <address@hidden>
>
> diff --git a/ui/curses.c b/ui/curses.c
> index 3a1b71451c..3bafc10c1c 100644
> --- a/ui/curses.c
> +++ b/ui/curses.c
> @@ -529,7 +529,7 @@ static void font_setup(void)
> * Control characters are normally non-printable, but VGA does have
> * well-known glyphs for them.
> */
> - static uint16_t control_characters[0x20] = {
> + static const uint16_t control_characters[0x20] = {
> 0x0020,
> 0x263a,
> 0x263b,
> --
> 2.21.1
>
[PATCH v2 3/9] hw/audio/intel-hda: Use memory region alias to reduce .rodata by 4.34MB, Philippe Mathieu-Daudé, 2020/03/05
[PATCH v2 4/9] hw/net/e1000: Add readops/writeops typedefs, Philippe Mathieu-Daudé, 2020/03/05
[PATCH v2 5/9] hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data, Philippe Mathieu-Daudé, 2020/03/05
[PATCH v2 6/9] hw/usb/quirks: Use smaller types to reduce .rodata by 10KiB, Philippe Mathieu-Daudé, 2020/03/05
[PATCH v2 8/9] ui/curses: Move arrays to .heap to save 74KiB of .bss, Philippe Mathieu-Daudé, 2020/03/05
[PATCH v2 7/9] ui/curses: Make control_characters[] array const, Philippe Mathieu-Daudé, 2020/03/05
- Re: [PATCH v2 7/9] ui/curses: Make control_characters[] array const,
Stefano Garzarella <=
[PATCH v2 9/9] virtfs-proxy-helper: Make the helper_opts[] array const, Philippe Mathieu-Daudé, 2020/03/05
Re: [PATCH v2 0/9] hw, ui, virtfs-proxy-helper: Reduce QEMU .data/.rodata/.bss footprint, no-reply, 2020/03/05
Re: [PATCH v2 0/9] hw, ui, virtfs-proxy-helper: Reduce QEMU .data/.rodata/.bss footprint, no-reply, 2020/03/05
Re: [PATCH v2 0/9] hw, ui, virtfs-proxy-helper: Reduce QEMU .data/.rodata/.bss footprint, Daniel P . Berrangé, 2020/03/05
Re: [PATCH v2 0/9] hw, ui, virtfs-proxy-helper: Reduce QEMU .data/.rodata/.bss footprint, no-reply, 2020/03/05
Re: [PATCH v2 0/9] hw, ui, virtfs-proxy-helper: Reduce QEMU .data/.rodata/.bss footprint, Eric Blake, 2020/03/05