qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 12/13] usb/hcd-ehci: Remove redundant statements


From: Gerd Hoffmann
Subject: Re: [PATCH v2 12/13] usb/hcd-ehci: Remove redundant statements
Date: Mon, 9 Mar 2020 11:13:29 +0100

On Wed, Feb 26, 2020 at 04:46:46PM +0800, address@hidden wrote:
> From: Chen Qun <address@hidden>
> 
> The "again" assignment is meaningless before g_assert_not_reached.
> In addition, the break statements no longer needs to be after
> g_assert_not_reached.
> 
> Clang static code analyzer show warning:
> hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read
>             again = -1;
>             ^       ~~
> 
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Patch added to usb queue.

thanks,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]