[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/12] monitor/hmp-cmds: Remove redundant statement in hmp
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v3 12/12] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() |
Date: |
Mon, 9 Mar 2020 13:58:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read
> set = true;
> ^ ~~~~
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Cc: "Dr. David Alan Gilbert" <address@hidden>
> Cc: Philippe Mathieu-Daudé <address@hidden>
>
> v1->v2: move the 'set' declaration to the for() statement(Base on Philippe's
> suggestion).
> ---
> monitor/hmp-cmds.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 53bc3f76c4..c6b0495822 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -2808,7 +2808,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict
> *qdict)
> const char *name = qdict_get_str(qdict, "name");
> uint8_t type = qdict_get_try_int(qdict, "type", 9);
> Error *err = NULL;
> - bool set = false;
>
> list = qmp_query_rocker_of_dpa_groups(name, type != 9, type, &err);
> if (err != NULL) {
> @@ -2820,6 +2819,7 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict
> *qdict)
>
> for (g = list; g; g = g->next) {
> RockerOfDpaGroup *group = g->value;
> + bool set = false;
>
> monitor_printf(mon, "0x%08x", group->id);
>
> @@ -2864,14 +2864,11 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const
> QDict *qdict)
>
> if (group->has_set_eth_dst) {
> if (!set) {
> - set = true;
> monitor_printf(mon, " set");
> }
> monitor_printf(mon, " dst %s", group->set_eth_dst);
> }
>
> - set = false;
> -
> if (group->has_ttl_check && group->ttl_check) {
> monitor_printf(mon, " check TTL");
> }
>
Applied to my trivial-patches branch.
Thanks,
Laurent
- Re: [PATCH v3 03/12] block/file-posix: Remove redundant statement in raw_handle_perm_lock(), (continued)
- [PATCH v3 09/12] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst(), Chen Qun, 2020/03/02
- [PATCH v3 08/12] display/blizzard: Remove redundant statement in blizzard_draw_line16_32(), Chen Qun, 2020/03/02
- [PATCH v3 01/12] block/stream: Remove redundant statement in stream_run(), Chen Qun, 2020/03/02
- [PATCH v3 00/12] redundant code: Fix warnings reported by Clang static code analyzer, Chen Qun, 2020/03/02
- [PATCH v3 12/12] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups(), Chen Qun, 2020/03/02
- [PATCH v3 10/12] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write(), Chen Qun, 2020/03/02
- [PATCH v3 05/12] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command(), Chen Qun, 2020/03/02