[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/12] block/iscsi:Remove redundant statement in iscsi_ope
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH v3 02/12] block/iscsi:Remove redundant statement in iscsi_open() |
|
Date: |
Tue, 10 Mar 2020 15:26:14 +0100 |
|
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 02.03.2020 um 14:07 hat Chen Qun geschrieben:
> Clang static code analyzer show warning:
> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
> flags &= ~BDRV_O_RDWR;
> ^ ~~~~~~~~~~~~
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> ---
> Cc: Ronnie Sahlberg <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Peter Lieven <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
>
> v1->v2:
> Keep the 'flags' then use it(Base on Kevin's comments).
I think this patch wants a different subject line now.
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 682abd8e09..50bae51700 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -2002,7 +2002,7 @@ static int iscsi_open(BlockDriverState *bs, QDict
> *options, int flags,
> iscsilun->cluster_size = iscsilun->bl.opt_unmap_gran *
> iscsilun->block_size;
> if (iscsilun->lbprz) {
> - ret = iscsi_allocmap_init(iscsilun, bs->open_flags);
> + ret = iscsi_allocmap_init(iscsilun, flags);
> }
> }
The code looks good.
Reviewed-by: Kevin Wolf <address@hidden>
[PATCH v3 06/12] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse(), Chen Qun, 2020/03/02
[PATCH v3 04/12] scsi/esp-pci: Remove redundant statement in esp_pci_io_write(), Chen Qun, 2020/03/02
[PATCH v3 03/12] block/file-posix: Remove redundant statement in raw_handle_perm_lock(), Chen Qun, 2020/03/02