[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Missing unlock_user_struct , Deadlock
|
From: |
Laurent Vivier |
|
Subject: |
Re: Missing unlock_user_struct , Deadlock |
|
Date: |
Fri, 13 Mar 2020 10:08:42 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Le 13/03/2020 à 05:52, Mansour Ahmadi a écrit :
> Hi
>
> In the case of badframe, user struct is not unlocked here and may lead
> to deadlock:
>
> https://github.com/qemu/qemu/blob/d4f7d56759f7c75270c13d5f3f5f736a9558929c/linux-user/m68k/signal.c#L380
badframe is called if lock fails, so no need to unlock.
> In similar case, it in unlocked correctly:
> https://github.com/qemu/qemu/blob/d4f7d56759f7c75270c13d5f3f5f736a9558929c/linux-user/sh4/signal.c#L303
ditto
Thanks,
Laurent