qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Compress lines for immediate return


From: Stefan Hajnoczi
Subject: Re: [PATCH v2] Compress lines for immediate return
Date: Fri, 3 Apr 2020 13:53:01 +0100

On Wed, Apr 01, 2020 at 10:23:14PM +0530, Simran Singhal wrote:
> Compress two lines into a single line if immediate return statement is found.
> 
> It also remove variables progress, val, data, ret and sock
> as they are no longer needed.
> 
> Remove space between function "mixer_load" and '(' to fix the
> checkpatch.pl error:-
> ERROR: space prohibited between function name and open parenthesis '('
> 
> Done using following coccinelle script:
> @@
> local idexpression ret;
> expression e;
> @@
> 
> -ret =
> +return
>      e;
> -return ret;
> 
> Signed-off-by: Simran Singhal <address@hidden>
> ---
> Changes in v2:
>       -Added coccinelle script wrote for changes in commit message.
> 
>  block/file-posix.c      | 3 +--
>  block/nfs.c             | 3 +--
>  block/nvme.c            | 4 +---
>  block/vhdx.c            | 3 +--
>  hw/audio/ac97.c         | 4 +---
>  hw/audio/adlib.c        | 5 +----
>  hw/display/cirrus_vga.c | 4 +---
>  migration/ram.c         | 4 +---
>  ui/gtk.c                | 3 +--
>  util/qemu-sockets.c     | 5 +----
>  10 files changed, 10 insertions(+), 28 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]