[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 7/9] hw/gpio/aspeed_gpio: Remove dead assignment
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 7/9] hw/gpio/aspeed_gpio: Remove dead assignment |
Date: |
Wed, 22 Apr 2020 15:31:50 +0200 |
Fix warning reported by Clang static code analyzer:
hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its
initialization is never read
int set_idx, g_idx = *group_idx;
^~~~~ ~~~~~~~~~~
Reported-by: Clang Static Analyzer
Reviewed-by: Cédric Le Goater <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/gpio/aspeed_gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c
index 41e11ea9b0..bd19db31f4 100644
--- a/hw/gpio/aspeed_gpio.c
+++ b/hw/gpio/aspeed_gpio.c
@@ -714,7 +714,7 @@ static void aspeed_gpio_write(void *opaque, hwaddr offset,
uint64_t data,
static int get_set_idx(AspeedGPIOState *s, const char *group, int *group_idx)
{
AspeedGPIOClass *agc = ASPEED_GPIO_GET_CLASS(s);
- int set_idx, g_idx = *group_idx;
+ int set_idx, g_idx;
for (set_idx = 0; set_idx < agc->nr_gpio_sets; set_idx++) {
const GPIOSetProperties *set_props = &agc->props[set_idx];
--
2.21.1
- [PATCH v3 0/9] misc: Trivial static code analyzer fixes, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 2/9] blockdev: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 1/9] block: Avoid dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 4/9] hw/input/adb-kbd: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 3/9] hw/i2c/pm_smbus: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 5/9] hw/ide/sii3112: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 6/9] hw/isa/i82378: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 7/9] hw/gpio/aspeed_gpio: Remove dead assignment,
Philippe Mathieu-Daudé <=
- [PATCH v3 9/9] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 8/9] hw/timer/stm32f2xx_timer: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22