[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 15/19] hw/ide/sii3112: Remove dead assignment
From: |
Laurent Vivier |
Subject: |
[PULL v2 15/19] hw/ide/sii3112: Remove dead assignment |
Date: |
Mon, 4 May 2020 17:59:52 +0200 |
From: Philippe Mathieu-Daudé <address@hidden>
Fix warning reported by Clang static code analyzer:
CC hw/ide/sii3112.o
hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read
val = 0;
^ ~
Fixes: a9dd6604
Reported-by: Clang Static Analyzer
Reviewed-by: BALATON Zoltan <address@hidden>
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
hw/ide/sii3112.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c
index d69079c3d9b7..94d2b57f9535 100644
--- a/hw/ide/sii3112.c
+++ b/hw/ide/sii3112.c
@@ -42,7 +42,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr addr,
unsigned int size)
{
SiI3112PCIState *d = opaque;
- uint64_t val = 0;
+ uint64_t val;
switch (addr) {
case 0x00:
@@ -126,6 +126,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr addr,
break;
default:
val = 0;
+ break;
}
trace_sii3112_read(size, addr, val);
return val;
@@ -201,7 +202,7 @@ static void sii3112_reg_write(void *opaque, hwaddr addr,
d->regs[1].sien = (val >> 16) & 0x3eed;
break;
default:
- val = 0;
+ break;
}
}
--
2.26.2
- [PULL v2 07/19] elf_ops: Don't try to g_mapped_file_unref(NULL), (continued)
- [PULL v2 07/19] elf_ops: Don't try to g_mapped_file_unref(NULL), Laurent Vivier, 2020/05/04
- [PULL v2 08/19] MAINTAINERS: Update Keith Busch's email address, Laurent Vivier, 2020/05/04
- [PULL v2 03/19] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write(), Laurent Vivier, 2020/05/04
- [PULL v2 12/19] blockdev: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 01/19] scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write(), Laurent Vivier, 2020/05/04
- [PULL v2 10/19] Compress lines for immediate return, Laurent Vivier, 2020/05/04
- [PULL v2 09/19] chardev: Add macOS to list of OSes that support -chardev serial, Laurent Vivier, 2020/05/04
- [PULL v2 13/19] hw/i2c/pm_smbus: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 17/19] hw/gpio/aspeed_gpio: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 19/19] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning, Laurent Vivier, 2020/05/04
- [PULL v2 15/19] hw/ide/sii3112: Remove dead assignment,
Laurent Vivier <=
- [PULL v2 11/19] block: Avoid dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 14/19] hw/input/adb-kbd: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 16/19] hw/isa/i82378: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 18/19] hw/timer/stm32f2xx_timer: Remove dead assignment, Laurent Vivier, 2020/05/04
- Re: [PULL v2 00/19] Trivial branch for 5.1 patches, Peter Maydell, 2020/05/05