Re: [PATCH v2] crypto: Redundant type conversion for AES_KEY pointer

[Daniel P . Berrangé]

On Tue, May 05, 2020 at 04:59:40PM +0800, Chen Qun wrote:
> We can delete the redundant type conversion if
> we set the the AES_KEY parameter with 'const' in
> qcrypto_cipher_aes_ecb_(en|de)crypt() function.
> 
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> ---
> v1->v2:
> Cc: "Daniel P. Berrangé" <address@hidden>
> 
> Modify the AES_KEY parameter with 'const' in
> qcrypto_cipher_aes_ecb_(en|de)crypt() methods.
> (Base on Daniel P. Berrangé's suggestion)
> 
> https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg00515.html
> 
> ---
>  crypto/cipher-builtin.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <address@hidden>

and queued - will send a PR with this and some other crypto fixes later
today most likely.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|