Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

[Philippe Mathieu-Daudé]

On 5/25/20 1:02 PM, Fred Konrad wrote:
> Sorry Philippe I missed that.
> 
> Would be happy to do a PR if needed but:
>   * I never did that.
>   * Looking at https://wiki.qemu.org/Contribute/SubmitAPullRequest, I
> don't have
>     the signed GPG key either.

Thanks Fred for following this series.

I am not insisting for you to do the pull request, I was waiting for
Artyom (sparc32) and Mark (sparc64) who usually handle the pull requests.

Artyom seems busy lately.

Mark, do you plan to send a hw/sparc* pull request soon? Do you prefer I
ask to trivial@ for this series?

FYI there is another sparc32 candidate patch:
https://www.mail-archive.com/address@hidden/msg701850.html

Regards,

Phil.

> 
> Cheers,
> Fred
> 
> Le 5/23/20 à 7:26 PM, Philippe Mathieu-Daudé a écrit :
>> ping?
>>
>> On 5/11/20 9:03 AM, Philippe Mathieu-Daudé wrote:
>>> On 4/14/20 12:00 PM, KONRAD Frederic wrote:
>>>> Le 4/13/20 à 11:07 PM, Philippe Mathieu-Daudé a écrit :
>>>>> [Cc'ing Peter]
>>>>>
>>>>> On 4/13/20 12:12 PM, KONRAD Frederic wrote:
>>>>>> Le 4/11/20 à 7:30 PM, Philippe Mathieu-Daudé a écrit :
>>>>>>> On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
>>>>>>>> Philippe Mathieu-Daudé (7):
>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>>>>>>>>        registers
>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
>>>>>>>
>>>>>>> Ping ^^^ for 5.0?
>>>>>>
>>>>>> Hi Philippe,
>>>>>>
>>>>>> You already have my rb tag for those one, and IMHO they should be
>>>>>> good
>>>>>> candidate
>>>>>> for 5.0 (if it's not too late).
>>>>>
>>>>> Yes, thanks for the reviews. I see Mark Cave-Ayland merged this file
>>>>> first, but you are listed as maintainer :) I was hoping you could
>>>>> send a
>>>>> pull request.
>>>>
>>>> Yes that's usually Mark who take the patches, sorry I didn't get it.
>>>
>>> No worries. As there are other sparc64 patches on the list, maybe Mark
>>> will prepare a pull request now.
>>>
>>>>
>>>>>
>>>>> $ scripts/get_maintainer.pl -f hw/misc/grlib_ahb_apb_pnp.c
>>>>> Fabien Chouteau <address@hidden> (maintainer:Leon3)
>>>>> KONRAD Frederic <address@hidden> (maintainer:Leon3)
>>>>> address@hidden (open list:All patches CC here)
>>>>>
>>>>
>>>>> This is a bug but not 'security critical', so it might wait 5.1 and go
>>>>> via qemu-trivial tree.
>>>>
>>>> Well let's do that then if you're ok.
>>>
>>> OK, then ping? :)
>>>
>>>>
>>>> Best Regards,
>>>> Fred
>>>>
>>>>>
>>>>> Regards,
>>>>>
>>>>> Phil.
>>>>>
>>>>>>
>>>>>> Cheers,
>>>>>> Fred
>>>>>>
>>>>>>>
>>>>>>>>      hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>>>>>>>>      hw/timer/grlib_gptimer: Display frequency in decimal
>>>>>>>>      target/sparc/int32_helper: Remove DEBUG_PCALL definition
>>>>>>>>      target/sparc/int32_helper: Extract and use excp_name_str()
>>>>>>>>
>>>>>>>>     hw/misc/grlib_ahb_apb_pnp.c             | 24
>>>>>>>> ++++++++++++++++++++++--
>>>>>>>>     target/sparc/int32_helper.c             | 23
>>>>>>>> ++++++++++++-----------
>>>>>>>>     hw/misc/trace-events                    |  4 ++++
>>>>>>>>     hw/timer/trace-events                   |  2 +-
>>>>>>>>     tests/acceptance/machine_sparc_leon3.py |  4 ++++
>>>>>>>>     5 files changed, 43 insertions(+), 14 deletions(-)
>>>>>>>>
>>>>>>
>>>>
>>>
>