qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] hax: Fix setting of FD_CLOEXEC


From: Eric Blake
Subject: Re: [PATCH 1/2] hax: Fix setting of FD_CLOEXEC
Date: Tue, 2 Jun 2020 12:47:50 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 4/20/20 5:07 PM, Eduardo Habkost wrote:
On Mon, Apr 20, 2020 at 12:53:07PM -0500, Eric Blake wrote:
Blindly setting FD_CLOEXEC without a read-modify-write will
inadvertently clear any other intentionally-set bits, such as a
proposed new bit for designating a fd that must behave in 32-bit mode.
Use our wrapper function instead of an incorrect hand-rolled version.

Signed-off-by: Eric Blake <eblake@redhat.com>

Thanks, queued for 5.1.

Ping - I still don't see this upstream.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]