[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] hw/net/opencores_eth: Remove unnecessary address masking
From: |
Max Filippov |
Subject: |
Re: [PATCH 2/2] hw/net/opencores_eth: Remove unnecessary address masking |
Date: |
Mon, 8 Jun 2020 02:27:36 -0700 |
On Mon, Jun 8, 2020 at 2:15 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The memory region is limited to 1 KiB, so the address is
> garantied to be in that range. No need to mask.
>
> 711 static const MemoryRegionOps open_eth_desc_ops = {
> 712 .read = open_eth_desc_read,
> 713 .write = open_eth_desc_write,
> 714 };
> ...
> 725 memory_region_init_io(&s->desc_io, OBJECT(dev),
> 725 &open_eth_desc_ops, s,
> 726 "open_eth.desc", 0x400);
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/net/opencores_eth.c | 2 --
> 1 file changed, 2 deletions(-)
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
--
Thanks.
-- Max