Re: [PATCH v2 4/8] hw/sh4: Use MemoryRegion typedef

[Thomas Huth]

On 08/06/2020 11.01, Philippe Mathieu-Daudé wrote:
> Use the MemoryRegion type defined in "qemu/typedefs.h",
> to keep the repository style consistent.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Message-Id: <20200504081653.14841-2-f4bug@amsat.org>
> ---
>  include/hw/sh4/sh.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/include/hw/sh4/sh.h b/include/hw/sh4/sh.h
> index 767a2df7e2..fe773cb01d 100644
> --- a/include/hw/sh4/sh.h
> +++ b/include/hw/sh4/sh.h
> @@ -10,9 +10,8 @@
>  
>  /* sh7750.c */
>  struct SH7750State;
> -struct MemoryRegion;
>  
> -struct SH7750State *sh7750_init(SuperHCPU *cpu, struct MemoryRegion *sysmem);
> +struct SH7750State *sh7750_init(SuperHCPU *cpu, MemoryRegion *sysmem);
>  
>  typedef struct {
>      /* The callback will be triggered if any of the designated lines change 
> */
> @@ -32,7 +31,7 @@ int sh7750_register_io_device(struct SH7750State *s,
>  #define TMU012_FEAT_TOCR   (1 << 0)
>  #define TMU012_FEAT_3CHAN  (1 << 1)
>  #define TMU012_FEAT_EXTCLK (1 << 2)
> -void tmu012_init(struct MemoryRegion *sysmem, hwaddr base,
> +void tmu012_init(MemoryRegion *sysmem, hwaddr base,
>                   int feat, uint32_t freq,
>                qemu_irq ch0_irq, qemu_irq ch1_irq,
>                qemu_irq ch2_irq0, qemu_irq ch2_irq1);
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>