|
From: | Eric Blake |
Subject: | Re: [PATCH] hw/openrisc/openrisc_sim: Add assertion to silent GCC warning |
Date: | Tue, 9 Jun 2020 15:49:55 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/9/20 3:42 PM, Stafford Horne wrote:
While humans can tell smp_cpus will always be in the [1, 2] range, (openrisc_sim_machine_init sets mc->max_cpus = 2), the compiler can't. Add an assertion to give the compiler a hint there's no use of uninitialized data.
Acked-by: Stafford Horne <shorne@gmail.com> I see there are now two patches for this, I kind of like this assert fix. Shall I queue it for OpenRISC pulling? Or can someone else pick this up?
Looks like Laurent already volunteered to queue it through the trivial patches tree.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |