Re: [PATCH v3 05/11] MAINTAINERS: Add an entry for common Renesas peripherals

[Philippe Mathieu-Daudé]

On 6/11/20 9:38 AM, Thomas Huth wrote:
> On 11/06/2020 00.08, Philippe Mathieu-Daudé wrote:
>> Renesas peripherals are common to SH4/RX based MCUs. Their
>> datasheets share common sections. It makes sense to maintain
>> them altogether. The current names are misleading (see the
>> 'sh' prefix). This will be fixed later when RX peripherals
>> will be added.
>>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  MAINTAINERS | 9 +++++++--
>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 653fca1da8..0398634179 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1254,8 +1254,6 @@ M: Magnus Damm <magnus.damm@gmail.com>
>>  S: Odd Fixes
>>  F: hw/sh4/r2d.c
>>  F: hw/intc/sh_intc.c
>> -F: hw/timer/sh_timer.c
>> -F: include/hw/sh4/sh_intc.h
> 
> You've added the line for sh_intc.h in the previous patch, just to
> remove it here again? ... I guess you only wanted to remove sh_timer.c
> here instead?

Yes, you are right, too many rework trying to split in a way that
would satisfy Aleksander requirements, but he eventually implicitly
Nacked this series (not replying on the cover however, and not
answering my questions, so this is not clear neither...):
https://www.mail-archive.com/qemu-devel@nongnu.org/msg711260.html
Aleksander said Yoshinori will arrange the sections in his own
ways. While I'm not certain Yoshinori is interested/willing to do
the cleanup, I don't think any more reviewer should spend time
reviewing this. Thanks for caring anyway, very appreciated!

> 
>  Thomas
> 
>>  Shix
>>  S: Orphan
>> @@ -1954,6 +1952,13 @@ F: hw/*/*xive*
>>  F: include/hw/*/*xive*
>>  F: docs/*/*xive*
>>  
>> +Renesas peripherals
>> +M: Magnus Damm <magnus.damm@gmail.com>
>> +S: Odd Fixes
>> +F: hw/char/sh_serial.c
>> +F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/sh.h
>> +
>>  Subsystems
>>  ----------
>>  Audio
>>
>