[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/audio/gus: Fix registers 32-bit access
|
From: |
Thomas Huth |
|
Subject: |
Re: [PATCH] hw/audio/gus: Fix registers 32-bit access |
|
Date: |
Thu, 18 Jun 2020 06:57:07 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 18/06/2020 00.25, Allan Peramaki wrote:
> On 17/06/2020 23:23, Peter Maydell wrote:
>>
>> This patch is quite difficult to read because it mixes some
>> whitespace only changes with some actual changes of
>> behaviour.
>
> Sorry about that. I had to put some whitespace in the two lines I
> modified because of checkpatch.pl, but then the nearby lines would have
> had inconsistent style if left unmodified.
Hi Allan!
Makes perfect sense, but for the review, it might have been helpful if
you'd put this information in the commit message.
Anyway, the change looks correct to me, so:
Reviewed-by: Thomas Huth <thuth@redhat.com>