qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] define SIGIO for haiku


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 2/3] define SIGIO for haiku
Date: Fri, 26 Jun 2020 16:08:33 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

Maybe "Define SIGIO on Haiku OS" as patch subject...

On 6/26/20 4:03 PM, David CARLIER wrote:
> From d36aba6190152c626f668fef3704ee6b61bfc323 Mon Sep 17 00:00:00 2001
> From: David Carlier <devnexen@gmail.com>
> Date: Fri, 26 Jun 2020 13:45:04 +0000
> Subject: [PATCH 2/3] define SIGIO for haiku
> 
> Signed-off-by: David Carlier <devnexen@gmail.com>
> ---
>  include/qemu/osdep.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index f88fe23936..860bb3c16c 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -388,6 +388,10 @@ void qemu_anon_ram_free(void *ptr, size_t size);
>  #define HAVE_CHARDEV_PARPORT 1
>  #endif
> 
> +#if defined(__HAIKU__)

Maybe safer as:

   #if defined(__HAIKU__) && !defined(SIGIO)

> +#define SIGIO SIGPOLL
> +#endif
> +
>  #if defined(CONFIG_LINUX)
>  #ifndef BUS_MCEERR_AR
>  #define BUS_MCEERR_AR 4
> 

Preferably with the suggested changes:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]