[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] target/nios2: in line the semantics of DISAS_UPDATE with
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 2/3] target/nios2: in line the semantics of DISAS_UPDATE with other targets |
|
Date: |
Thu, 2 Jul 2020 11:25:54 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 7/2/20 11:14 AM, Richard Henderson wrote:
> On 6/29/20 9:05 AM, Wentong Wu wrote:
>> In line the semantics of DISAS_UPDATE on nios2 target with other targets
>> which is to explicitly write the PC back into the cpu state before doing
>> a tcg_gen_exit_tb().
>>
>> Signed-off-by: Wentong Wu <wentong.wu@intel.com>
>> ---
>> target/nios2/translate.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Or simply remove it as unused, now that you've replaced the existing users
> with
> DISAS_NORETURN.
Nevermind, you're using it in the next patch.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~