[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] softmmu/vl: Remove the check for colons in -accel parameters
From: |
Claudio Fontana |
Subject: |
Re: [PATCH] softmmu/vl: Remove the check for colons in -accel parameters |
Date: |
Fri, 3 Jul 2020 09:28:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 7/3/20 7:34 AM, Thomas Huth wrote:
> On 18/06/2020 09.40, Thomas Huth wrote:
>> The new -accel option does not accept colons in the parameters anymore
>> (since it does not convert the parameters to -machine accel=... parameters
>> anymore). Thus we can now remove the check for colons in -accel:
>>
>> $ qemu-system-x86_64 -accel kvm:tcg
>> qemu-system-x86_64: -accel kvm:tcg: invalid accelerator kvm:tcg
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> softmmu/vl.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/softmmu/vl.c b/softmmu/vl.c
>> index f669c06ede..273acfcf6b 100644
>> --- a/softmmu/vl.c
>> +++ b/softmmu/vl.c
>> @@ -3485,11 +3485,6 @@ void qemu_init(int argc, char **argv, char **envp)
>> g_slist_free(accel_list);
>> exit(0);
>> }
>> - if (optarg && strchr(optarg, ':')) {
>> - error_report("Don't use ':' with -accel, "
>> - "use -M accel=... for now instead");
>> - exit(1);
>> - }
>> break;
>> case QEMU_OPTION_usb:
>> olist = qemu_find_opts("machine");
>>
>
> Ping?
>
> Thomas
>
>
Reviewed-by: Claudio Fontana <cfontana@suse.de>