Re: [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro

[Michele Denber]

On 07/06/20 13:04, Laurent Vivier wrote:
> Le 04/07/2020 à 20:13, Michele Denber a écrit :
> > On 07/04/20 13:11, Thomas Huth wrote:
> > > On 04/07/2020 11.23, Peter Maydell wrote:
> > > > In commit a8d2532645cf5ce4 we cleaned up usage of the qemu-common.h header
> > > > so that it was always included from .c files and never from other .h files.
> > > > We missed adding it to net/tap-solaris.c (which previously was pulling it
> > > > in via tap-int.h), which broke building on Solaris hosts.
> > > >
> > > > Fixes: a8d2532645cf5ce4
> > > > Reported-by: Michele Denber<denber@mindspring.com>
> > > > Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> > > > ---
> > > > Untested: Michele, could you give this a try?
> > > > ---
> > > >   net/tap-solaris.c | 1 +
> > > >   1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/net/tap-solaris.c b/net/tap-solaris.c
> > > > index 4725d2314ee..d03165c57c9 100644
> > > > --- a/net/tap-solaris.c
> > > > +++ b/net/tap-solaris.c
> > > > @@ -27,6 +27,7 @@
> > > >   #include "tap_int.h"
> > > >   #include "qemu/ctype.h"
> > > >   #include "qemu/cutils.h"
> > > > +#include "qemu-common.h"
> > > >
> > > >   #include<sys/ethernet.h>
> > > >   #include<sys/sockio.h>
> > I can confirm that this works in Solaris 11.4:
> >
> > root@hemlock:~/qemu-5.0.0# gpatch -p1<  tap-solaris.patch.diff
> > patching file net/tap-solaris.c
> > root@hemlock:~/qemu-5.0.0#
> Do you mean building on Solaris hosts works well now?
In that message I meant that the tap-solaris patch worked.  However, 
yes, I have now successfully built all of QEMU 5.0 on Solaris 11.4 SPARC.
> In this case, you can add a "Tested-by:" tag.
I'd be glad to but how do I do that?

            - Michele