[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qdev: Document qdev_prop_set_drive_err() return value
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH] qdev: Document qdev_prop_set_drive_err() return value |
|
Date: |
Wed, 22 Jul 2020 09:20:42 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> Since commit 73ac1aac39 qdev_prop_set_drive_err() returns
> a boolean value. Document it.
>
> Fixes: 73ac1aac39 "Make functions taking Error ** return bool, not void"
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/qdev-properties.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 587e5b7d31..3a64d5ab9a 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -238,6 +238,8 @@ extern const PropertyInfo qdev_prop_pcie_link_width;
>
> /*
> * Set properties between creation and realization.
> + *
> + * Returns: %true on success, %false on error.
> */
> bool qdev_prop_set_drive_err(DeviceState *dev, const char *name,
> BlockBackend *value, Error **errp);
Reviewed-by: Markus Armbruster <armbru@redhat.com>