[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs |
|
Date: |
Thu, 23 Jul 2020 15:42:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/23/20 3:22 PM, Thomas Huth wrote:
> The dependency on curses has been removed in commit c7a856b42e403e2b
> ("target/unicore32: Prefer qemu_semihosting_log_out() over curses").
> So we can remove the related lines in the Makefile now, too.
Don't we also need to remove all uses of CONFIG_CURSES to
be complete? Eventually display a warning with --(en|dis)able-curses
is used.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/unicore32/Makefile.objs | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/target/unicore32/Makefile.objs b/target/unicore32/Makefile.objs
> index 35d8bf530d..6b41b1e9ef 100644
> --- a/target/unicore32/Makefile.objs
> +++ b/target/unicore32/Makefile.objs
> @@ -2,7 +2,3 @@ obj-y += translate.o op_helper.o helper.o cpu.o
> obj-y += ucf64_helper.o
>
> obj-$(CONFIG_SOFTMMU) += softmmu.o
> -
> -# Huh? Uses curses directly instead of using ui/console.h interfaces ...
> -helper.o-cflags := $(CURSES_CFLAGS)
> -helper.o-libs := $(CURSES_LIBS)
>