[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs
From: |
Peter Maydell |
Subject: |
Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs |
Date: |
Thu, 23 Jul 2020 15:50:24 +0100 |
On Thu, 23 Jul 2020 at 14:23, Thomas Huth <thuth@redhat.com> wrote:
>
> The dependency on curses has been removed in commit c7a856b42e403e2b
> ("target/unicore32: Prefer qemu_semihosting_log_out() over curses").
> So we can remove the related lines in the Makefile now, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Another, unrelated, CONFIG_CURSES oddity:
hw/input/virtio-input-hid.c has an "#undef CONFIG_CURSES"
before it includes ui/console.h. But that header file
doesn't do anything different if CONFIG_CURSES is defined,
so I think the undef is now useless and can be removed.
thanks
-- PMM