[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs |
Date: |
Thu, 23 Jul 2020 17:11:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/23/20 3:45 PM, Thomas Huth wrote:
> On 23/07/2020 15.42, Philippe Mathieu-Daudé wrote:
>> On 7/23/20 3:22 PM, Thomas Huth wrote:
>>> The dependency on curses has been removed in commit c7a856b42e403e2b
>>> ("target/unicore32: Prefer qemu_semihosting_log_out() over curses").
>>> So we can remove the related lines in the Makefile now, too.
>>
>> Don't we also need to remove all uses of CONFIG_CURSES to
>> be complete? Eventually display a warning with --(en|dis)able-curses
>> is used.
>
> Which ones do you mean? I can't find any other CONFIG_CURSES anymore in
> the target/ folder...
>
> Or do you also plan to get rid of ui/curses.c ??? ... that's certainly
> another story.
Ah indeed.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>