[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 0/4] Fixes curses on msys2/mingw
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v6 0/4] Fixes curses on msys2/mingw |
Date: |
Fri, 2 Oct 2020 16:38:01 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Fri, Oct 02, 2020 at 02:47:44PM +0200, Gerd Hoffmann wrote:
> On Thu, Oct 01, 2020 at 07:39:33PM +0200, Paolo Bonzini wrote:
> > On 01/10/20 19:32, Yonggang Luo wrote:
> > > And also convert related configure script to meson.
> > > V5-V6
> > > Dropping configure: Fixes ncursesw detection under msys2/mingw by convert
> > > the=
> > > m to meson first.
> > > That need the meson 0.56 upstream to fixes the curses detection.
> > > Add
> > > * configure: fixes indent of $meson setup
> > >
> > > Yonggang Luo (4):
> > > configure: fixes indent of $meson setup
> > > curses: Fixes compiler error that complain don't have langinfo.h on
> > > msys2/mingw
> > > curses: Fixes curses compiling errors.
> > > win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE
> > > are defined on msys2/mingw
> > >
> > > configure | 42 ++++-----------------------------------
> > > include/sysemu/os-win32.h | 4 ++--
> > > ui/curses.c | 14 ++++++-------
> > > util/oslib-win32.c | 4 ++--
> > > 4 files changed, 15 insertions(+), 49 deletions(-)
> > >
> > > --=20
> > > 2.28.0.windows.1
> > >
> > >
> >
> > Looks good (though there is no conversion to meson yet in this version).
> >
> > Not trivial, but perhaps Gerd can take it?
>
> Sure, series looks good.
>
> Can't finish this today due to -ENOTIME and I'm offline next week so
> this has to wait a bit in the UI patch queue ...
Patch 2 needs more work I think, as its missing the corresponding
configure change.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw, (continued)
- Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw, Daniel P . Berrangé, 2020/10/02
- Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw, Paolo Bonzini, 2020/10/02
- Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw, Yonggang Luo, 2020/10/02
- Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw, Paolo Bonzini, 2020/10/02
- Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw, Yonggang Luo, 2020/10/02
[PATCH v6 3/4] curses: Fixes curses compiling errors., Yonggang Luo, 2020/10/01
[PATCH v6 4/4] win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw, Yonggang Luo, 2020/10/01
Re: [PATCH v6 0/4] Fixes curses on msys2/mingw, Paolo Bonzini, 2020/10/01