[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/14] goldfish_rtc: change MemoryRegionOps endianness to DEVICE_N
From: |
Laurent Vivier |
Subject: |
[PULL 11/14] goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN |
Date: |
Tue, 13 Oct 2020 13:50:49 +0200 |
From: Laurent Vivier <lvivier@redhat.com>
The doc [1] doesn't define the endianness, but the kernel driver
uses readl() to access the registers, so we can guess it depends
on the architecture endianness.
As riscv architecture endianness is little it might not change anything
for it.
Moreover, android implementation uses DEVICE_NATIVE_ENDIAN [2]
[1]
https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
[2]
https://android.googlesource.com/platform/external/qemu/+/refs/heads/emu-master-dev/hw/timer/goldfish_timer.c#177
Fixes: 9a5b40b84279 ("hw: rtc: Add Goldfish RTC device")
Cc: Anup.Patel@wdc.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20201009113843.60995-2-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/rtc/goldfish_rtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rtc/goldfish_rtc.c b/hw/rtc/goldfish_rtc.c
index 6ddd45cce039..0f4e8185a796 100644
--- a/hw/rtc/goldfish_rtc.c
+++ b/hw/rtc/goldfish_rtc.c
@@ -217,7 +217,7 @@ static int goldfish_rtc_post_load(void *opaque, int
version_id)
static const MemoryRegionOps goldfish_rtc_ops = {
.read = goldfish_rtc_read,
.write = goldfish_rtc_write,
- .endianness = DEVICE_LITTLE_ENDIAN,
+ .endianness = DEVICE_NATIVE_ENDIAN,
.valid = {
.min_access_size = 4,
.max_access_size = 4
--
2.26.2
- [PULL 01/14] qemu-img-cmds.hx: Update comment that mentions Texinfo, (continued)
- [PULL 01/14] qemu-img-cmds.hx: Update comment that mentions Texinfo, Laurent Vivier, 2020/10/13
- [PULL 02/14] target/i386/cpu: Update comment that mentions Texinfo, Laurent Vivier, 2020/10/13
- [PULL 04/14] tests/test-char: Use a proper fallthrough comment, Laurent Vivier, 2020/10/13
- [PULL 03/14] hw/block/nvme: Simplify timestamp sum, Laurent Vivier, 2020/10/13
- [PULL 07/14] softmmu/memory: Log invalid memory accesses, Laurent Vivier, 2020/10/13
- [PULL 06/14] hw/acpi/piix4: Rename piix4_pm_add_propeties() to piix4_pm_add_properties(), Laurent Vivier, 2020/10/13
- [PULL 08/14] hw/pci: Fix typo in PCI hot-plug error message, Laurent Vivier, 2020/10/13
- [PULL 12/14] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry, Laurent Vivier, 2020/10/13
- [PULL 09/14] block/blkdebug: fix memory leak, Laurent Vivier, 2020/10/13
- [PULL 10/14] hw/char/serial: remove duplicate .class_init in serial_mm_info, Laurent Vivier, 2020/10/13
- [PULL 11/14] goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN,
Laurent Vivier <=
- [PULL 13/14] mingw: fix error __USE_MINGW_ANSI_STDIO redefined, Laurent Vivier, 2020/10/13
- [PULL 05/14] vmdk: fix maybe uninitialized warnings, Laurent Vivier, 2020/10/13
- [PULL 14/14] meson.build: drop duplicate 'sparc64' entry, Laurent Vivier, 2020/10/13
- Re: [PULL 00/14] Trivial branch for 5.2 patches, Peter Maydell, 2020/10/13